Skip to content

feat(v2): consolidated V2 plugin: 1.0.x ports, V2 spec alignment, inline CSR default - #39

Open
spbsoluble wants to merge 277 commits into
release-2.0from
feat/v2-consolidated
Open

spbsoluble wants to merge 277 commits into
release-2.0from
feat/v2-consolidated

Conversation

@spbsoluble

@spbsoluble spbsoluble commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Brings the whole V2 line into one branch: everything from #30, the 1.0.x fixes it was missing, and changes to match CERTInext's V2 API spec (2.0.0). It also contains #40, #41, #42, #43, #44, #46, #49, #50, #51, #52 and #53, which were merged into this branch. Replaces #30.

Breaking Changes

  • The certificate pickup now waits at most 75 s (was 180 s), in V1 and V2.
  • V2InlineCsr now defaults to true. A connector that already saved false keeps it; the upgrade note explains why to change it.

Features

Fixes

Chores

Testing

…e/chain tests

LoadEnvFile was seeding process env last, so the V1 CERTINEXT_API_URL (promoted
by IntegrationTestFixture with /emSignHub-API suffix) overwrote the V2 base URL
from ~/.env_certinext_v2, causing 404 on /oauth/token. Invert merge priority so
V2-file-defined keys always win, then force-promote them back into process env.

Add s_lastCreatedOrderId static so Lifecycle_V2_EnrollTrackRevoke can pass its
order ID to Revoke_V2_IssuedOrder and ChainPem_V2_IsAssembled. Both tests fall
back to the lifecycle ID when CERTINEXT_V2_ISSUED_ORDER_ID is absent, and skip
gracefully on sandbox-timing 422s instead of hard-failing.
…ecycleTests from no-DCV build

Prepares the test project for new V2 plugin-level lifecycle tests: the bulk
test's opt-in flag must not be auto-promoted from ~/.env_certinext, and the
upcoming V2DcvLifecycleTests.cs file (uses IDomainValidatorFactory) must be
excluded from the IAnyCAPlugin 3.2.0 no-DCV build like its V1 counterpart.
Adds a product-code presence check to GetProductDetails_V2_ReturnsProducts and
a links.self.href check to Lifecycle_V2_EnrollTrackRevoke. Both are logged
diagnostically rather than hard-asserted: a live run against the sandbox showed
neither field is currently populated by the V2 API for this account (see
issues/0016), so a hard assertion would make the suite flaky on an environment
limitation rather than a plugin regression.
Adds V2LifecycleTests.cs, exercising Enroll/Revoke/GetSingleRecord/Synchronize
through the plugin surface for the V2 (OAuth2) API path — the existing
V2ApiTests.cs only drove CERTInextClient methods directly. Sync-dependent
tests use a bounded delta window (fullSync=false) rather than a full pull of
this sandbox account's 1000+ historical orders, and the full-lifecycle
revoke step tolerates the same documented sandbox-timing rejection that
V2ApiTests.Revoke_V2_IssuedOrder already skips on.
Adds V2DcvLifecycleTests.cs (SUPPORTS_DCV-only, mirrors DcvLifecycleTests.cs's
split for V1) covering Enroll with DCV on/off, GetSingleRecord's deferred-DCV
retry, end-to-end DCV-on issuance appearing in sync, and the opt-in
algorithm-matrix/bulk-enrollment tests.

Also fixes two pre-existing compile errors in V2ApiTests.cs's own
#if SUPPORTS_DCV block (GetDcvV2Async/VerifyDcvV2Async missing a required
familySlug argument) discovered while getting a clean -p:DcvSupport=true
build to verify the new file — that region had apparently never been built
with DCV support enabled.
…add V2 unit coverage (G1, G2, G11, G12, 0023) (Phase 2)
…04/422, treat EMS-1080 as DCV satisfied (0019, 0020) (Phase 3)
…nto ApiUrl/OAuthClientId/OAuthClientSecret (0022) (Phase 4)

With UseV2Api=true, Synchronize now walks V2 /reports/orders (via new
ListOrdersV2Async) instead of falling back to V1 GetOrderReport, with an
incremental lookback window (V2SyncLookbackHours, default 72h) since the
from/to filter's order-date-vs-issue-date semantics couldn't be confirmed
live. Report-row status strings map to a disposition defensively, falling
back to a live TrackOrder call for anything unrecognized.

Removed the never-shipped ApiUrlV2/ClientId/ClientSecret fields outright;
V2 mode now uses the single ApiUrl (host follows UseV2Api) plus the
existing OAuthClientId/OAuthClientSecret fields, token URL
{ApiUrl}/oauth/token. V1 credentials are optional when UseV2Api is true.

Updated integration-manifest.json, docsource/configuration.md,
docsource/architecture.md, and CHANGELOG.md to match; issues/0022.md has
full implementation notes.
Settles which parser branch ParseProductDetailsV2Response needs before
touching it: GET /api/certinext/v2/catalog/products returns the same
nested category envelope as V1's GetProductDetails, confirmed live
against the sandbox account with and without groupNumber.
…016)

ParseProductDetailsV2Response deserialized each catalog/products array
element directly as ProductDetail, but the live response is a nested
category envelope (same shape as V1's GetProductDetails) -- every
element was actually a category, producing all-null ProductCode/
ProductName/ProductType/Active=false. Flatten per-element, mirroring
V1's FlattenProducts(), and keep the flat productId and bare-array
shapes as fallback branches.
ValidateProductInfo always called the V1-only GetProfilesAsync ->
GetProductDetailsAsync, which 404s against a V2-shaped ApiUrl -- a
hard block on registering any template with a ProductCode parameter
when UseV2Api=true. Branch on UseV2Api, mirroring
ValidateCAConnectionInfo's existing Ping/PingV2 branch: V2 now calls
GetProductDetailsV2Async and matches on ProductCode. No soft-accept
was added -- an empty/unusable V2 catalog throws the same "not found"
AnyCAValidationException V1 has always thrown for this case.
Drive CERTInextCAPlugin.ValidateProductInfo itself (not just the
client) against the sandbox account in both modes: V2 accepts the
configured code and rejects an unknown one without ever hitting the
V1-only GetProductDetails endpoint; V1 parity confirms unchanged
behavior. Also tighten GetProductDetails_V2_ReturnsProducts back to a
hard ProductCode assertion now that issue 0016 is fixed.
Checked-in source of truth for the V2 audit and every fix that follows —
cited throughout by folder/example/line in this session's issue triage.
Explains the single DcvSupport MSBuild property that selects the
IAnyCAPlugin version/DCV code fencing, and that the project now targets
only net10.0.
issues/ is a working log (see issues/README.md), not durable source —
untrack it along with .claude/, .codex/, CLAUDE.md, and AGENTS.md so
local working notes and agent tooling config stop showing as diffs.
issues/f3-v2-multi-san-limitation.md was the only previously-tracked file
under issues/; it is untracked here (file kept on disk, just no longer
in git).
…tilities

Read-only opt-in integration tests used during live triage: isolating
which enrollment field trips kfclab's "Inactive Account User" error, and
dumping TrackOrder/GetDcv state for orders stuck pending validation.
…ry revoke reason (0026, 0031, F3, 0028)

These four fixes land in one commit because each edits the same small set
of shared V2 plugin source files (EnrollV2Async/RevokeV2Async, the V2
request/response DTOs, and Constants.ApiV2) with no pre-session snapshot
available to separate them cleanly by issue — see
issues/V2_AUDIT_TRIAGE_HANDOFF.md for why. Per-issue test coverage is
committed separately right after this one.

- 0031: StatusMapper.V2StatusToRequestDisposition now maps all 11 V2 spec
  order statuses instead of defaulting 5 of them to FAILED; the unmapped
  default arm now logs a warning so it's distinguishable from a
  deliberate FAILED mapping.
- F3: EnrollV2Async detects UCC (multi-SAN) products from the live
  Catalog's productTypeID and populates V2CertificateParams.AdditionalDomains
  from the gateway SAN dictionary; the CSR-SAN-count fail-fast guard is
  unchanged (still spec-correct for UCC orders).
- 0028: EnrollV2Async sends the spec-mandatory organization block for
  OV/EV orders (organizationNumber + preVetted) from the existing
  OrganizationNumber config setting, and fails fast with a clear message
  instead of forwarding an incomplete block to a CA-side opaque 422.
- 0026: RevokeV2Async retries once with "cessation-of-operation" when
  CERTInext rejects Command's default "unspecified" revoke reason.
StatusMapperV2Tests covers all 11 spec status values plus the true
unrecognized-value default arm. V2ReportProbeTests gains a read-only
sandbox probe (opt-in) confirming which statuses the live account
actually returns. configuration.md's status table documents all 11.
V2UccEnrollmentTests drives Enroll end-to-end: UCC additionalDomains
population from the gateway SAN dictionary, non-UCC unaffected, the
CSR-SAN-count guard still fires first, and catalog-lookup failure fails
safe to non-UCC. CERTInextClientV2Tests covers wire serialization and
productTypeID surviving all three catalog response shapes.

Existing enroll/DCV dispatch tests in CERTInextCAPluginV2Tests and
CERTInextCAPluginV2DcvTests are updated to stub the new unconditional
GetProductDetailsV2Async call EnrollV2Async now makes. This same file
also carries two pre-existing regression tests for issue 0026's revoke
retry (added before this session, never previously committed) — kept
here rather than split out, since they live in the same file as the F3
stub updates.
V2OrganizationEnrollmentTests: organization block populated for ov/ev
from OrganizationNumber, omitted for dv, fail-fast FAILED result (no CA
call) when OrganizationNumber is unset for an OV/EV template, plus
DTO-level wire-serialization checks.

OrganizationBlockV2ProbeTests: opt-in live sandbox probes — confirmed
CERTInext hard-rejects an OV order with no organization block (HTTP 422
EMS-1180) and accepts it with the fix applied. Both probes were run live
this session with real-order cleanup verified; see
issues/0028-v2-organizationnumber-not-sent.md for the transcript.
…, 0028

- CHANGELOG.md: one bullet per fix (0026, 0031, F3, 0028).
- docsource/architecture.md: documents the 0026 revoke reason-code
  fallback and the revoke-note semicolon quirk.
- docsource/migration-v1-to-v2.md (new): V1-to-V2 migration guide,
  including corrected UCC/multi-domain support description (was
  previously going to state V2 has no multi-domain support at all) and
  the OrganizationNumber-is-now-mandatory-for-OV/EV note.
- README.md regenerated from docsource via doctooldotnet per this
  repo's convention (never hand-edited).
… one (0037)

A live fresh-domain DCV probe confirmed GetDcv's response is exactly
{tokenExpiryDate, token} — matching neither the DTO's old example shape
(orderNumber/domainName/dcvMethod/fileNameContent) nor the spec's prose
(method/txtToken). FileNameContent was always null on real orders, which
hit PerformDcvV2IfNeededAsync's null-token guard and stranded fresh-domain
DV orders at EXTERNALVALIDATION forever.

V2DcvChallengeResponse now models only Token/TokenExpiryDate; the other
fields are removed rather than left dead, since none exist on the wire.
The V2 path never actually read DcvMethod for method selection (DNS-TXT
and the _emudhra-challenge hostname are already hardcoded), and domain
name for TXT construction already comes from local order-placement
context, not this response — so dropping both is a no-op for existing
behavior.
Pins the real GetDcv wire shape ({tokenExpiryDate, token}) against the
client deserializer with the exact live JSON body from the issue's
probe, and against the plugin's PerformDcvV2IfNeededAsync to prove it
extracts and stages the token instead of hitting the null-token guard.
Updates the existing V2DcvChallengeResponse mock/JSON-builder usages to
match the fixed DTO shape.
…ID, not the V1-only DefaultProductCodes table

EnrollV2Async and ValidateProductInfo previously fell back to
Constants.Products.DefaultProductCodes when no explicit ProductCode override
was configured on a V2 template. That table's numbering is V1-era and does
not match the live V2 catalog (a flat +4 offset across all 10 codes), so an
administrator who left ProductCode unset on an OV/EV-named template could
silently order a different, lower-assurance product (0036).

Both callers now resolve/validate the code against the live catalog's
productTypeID field via a new Constants.Products.ProductTypeIdsV2 table
(ProductId -> CERTInext's documented numeric productTypeID). productTypeID
was used instead of matching on the catalog's productName (as originally
proposed) because live/spec evidence shows productName strings are not
stable across accounts, catalog versions, or validity-year suffixes and do
not match the ProductId strings GetProductIds() advertises -- whereas
productTypeID is the small, stable, CERTInext-documented enum the spec
itself recommends for this kind of routing decision, and F3 already
independently reached the same conclusion for UCC detection.

EnrollmentParams gains HasExplicitProductCode so V2 callers can distinguish
"explicit override configured" from "fell back to the V1 table" -- the V1
dispatch path (EnrollNewAsync/RenewOrReissueAsync) is untouched and still
uses the V1 table exactly as before. A catalog/productTypeID mismatch or
lookup miss now fails loudly instead of silently proceeding: EnrollV2Async
returns a FAILED result with a clear message, and ValidateProductInfo throws
AnyCAValidationException, in both the explicit-override and fallback cases.
…solution (0036)

Covers: EnrollV2Async resolving the live product code via catalog
productTypeID when no explicit ProductCode is configured, instead of the
stale V1 table; EnrollV2Async failing fast with a clear FAILED result when
no catalog entry matches the expected productTypeID; ValidateProductInfo
throwing on a code-exists-but-wrong-productTypeID mismatch (both explicit
override and no-override cases) that the pre-fix existence-only check would
have passed; and a new EnrollmentParamsTests.cs pinning that the V1-only
DefaultProductCodes fallback and HasExplicitProductCode behavior are
unchanged for all 10 product names.
…ort calls (0029)

V2 EnrollV2Async, GetProductDetailsV2Async, and ListOrdersV2Async never
carried the connector's configured GroupNumber, so V2 orders always
billed to and scoped against the account's default billing group.
Mirrors V1's existing DelegationInformation.GroupNumber / ProductDetailsFilter.GroupNumber
"send only if configured" semantics.
…ort calls (0029)

New V2GroupNumberEnrollmentTests.cs covers EnrollV2Async populating/omitting
GroupNumber on the V2CreateSslOrderRequest body, plus DTO serialization
presence/absence checks. CERTInextClientV2Tests.cs gains WireMock-based
GetProductDetailsV2Async/ListOrdersV2Async cases for the ?groupNumber= query
param, present when configured and omitted when not.
spbsoluble and others added 17 commits November 14, 2026 12:50
…ws through Track Order

The report row says fulfilled while the certificate status says pending; Track Order
returns issued (live: 1125823297). Preferring certificateStatus reported the order as
pending and never downloaded the certificate. That one shape (order maps issued,
certificate maps pending) now maps to null so the sync asks Track Order, and the pair
appears in UnmappedReportStatuses. Other disagreements keep their mapping.
FindSslComDomainAsync called GET /domains for every pending domain on every DCV
attempt, so a pass over many orders under one domain repeated the same lookup. A
per-pass cache (one per sync pass, one per Enroll/GetSingleRecord DCV call) keeps
found rows and "no row"; failed lookups aren't cached and fall back to emSign as
before. Only DomainId/validatedBy come from the cached row; DCV state is still read
fresh per order. Sync processes rows sequentially, so a plain dictionary.
…entry

Command fails the Keyfactor-Enroll workflow step at its global Workflow Step Run
Timeout (Workflow.General.Timeout, 60 s by default; the step has no timeout of its
own). The pickup budget (5 s + PickupRetries x PickupDelay, capped at 75 s) was
counted from the start of the pickup, so the create time came on top: on the lab a
new DV order and a reissue (26 s) both reached Command's 60 s, which recorded a
failure while the order went on at CERTInext.

New setting EnrollmentCallBudgetSeconds (default 50, 0 disables, clamped to 90 under
the 100 s HttpClient timeout). Enroll starts an EnrollmentDeadline, carried in an
AsyncLocal to the V1 new/renew and V2 pickups. They shorten waits to keep a 3 s poll
margin, skip the delay after the last poll, and stop with one Information line when
no poll fits. In-flight calls are never cut short; PickupRetries=0 is unchanged;
inline DCV is not bounded (documented as a known limitation).
… parameters

OrgRepresentativeName/Email (together) plus optional Phone/Designation/EmployeeId send
organization.useNewOrgRepresentative=true with an organizationRepresentative block on
a V2 OV create. ValidateProductInfo and EnrollV2CoreAsync share one check that mirrors
CERTInext's rules before any CA call: OV only (EMS-1315), a pre-vetted organization
(EMS-1316), name and email together (EMS-1319/1320), one email, phone 6-15 digits
(EMS-1321). Error messages name parameters, never values. V1 ignores them (warns at
save); a reissue doesn't send them. The create response's
organizationRepresentativeStatus is logged; pendingOrganizationRepresentative is kept
raw (undocumented shape) and only its presence logged.

Personal data: employeeId and the block keys join PersonalOtherFieldNames, and emails
inside CA error text (detail/title/message/errorMessage) in logged bodies are now
masked; an EMS-1317 error echoing the representative's email used to reach the
Warning-level V2 non-success line unmasked.
…prover' order

Opt-in (CERTINEXT_V2_FULFILLED_PENDING_SYNC=1), read-only. A DispatchProxy narrows the
real report listing to one order and forwards every other call to the real client, so
the actual Synchronize path runs live. Asserts the row defers to Track Order, comes out
issued, and has its certificate download attempted. Live 2026-11-15 on 1125823297:
Track issued, download 422 EMS-1165 (never generated), emitted issued without a body.
… its certificate isn't generated

Live on 1125823297: Track Order says issued, but Download Certificate answers 422
EMS-1165 for an order placed months before the sandbox stopped generating, so the
report's 'Pending for Approver' was right. Such a row (Track fallback said issued, the
report's certificate status maps to pending, download EMS-1165) is now emitted pending
instead of issued without a certificate. The download is still tried every pass, so
a certificate that appears is imported. Other download failures, and rows whose
report doesn't say pending, keep the issued-without-body behaviour.
…certificate and a pending certificate state

Matches the V2 sync rule: Track says issued, Download Certificate answers 422
EMS-1165, and the order's certificateState (same text as the report's
certificateStatus: Pending for Approver, Approved by System, Order Accepted) maps to
pending, so the record is pending rather than issued without a body. An
unrecognized or non-pending state, and other download failures, keep the existing
result. Docs no longer claim the plugin never acts on certificateState.
… certificate and a pending state

Opt-in with CERTINEXT_V2_FULFILLED_PENDING_SYNC=1, read-only, DCV off; orders from
CERTINEXT_V2_SINGLE_RECORD_ORDERS. Also relaxes nothing in the sync test, which now
expects pending without a body. Live 2026-11-16: 1125823297 (Pending for Approver)
and 6292373831 (Approved by System) both returned pending (90); the one-order sync
emitted 1125823297 pending.
…sign synced certificates a template

The gateway gives a synced record a certificate profile only when its ProductID
equals a configured template's ProductID (a GetProductIds() name) exactly
(Gateway-AnyCA-REST CertificateService.CreateOrUpdateDBCertificate, called only from
CASyncJob). Both syncs sent CERTInext product codes, which never matched: all 927
sync-created lab rows had no profile, and those certificates reached Command with no
template.

Each V1/V2 sync pass now reads the account catalog once (on first use) and names a
code by productTypeID via the inverse of ProductTypeIdsV2. No fixed code table: the
V1-era DefaultProductCodes would label the sandbox's DV 842 'OV SSL'. Unknown codes,
types with no plugin product, and an unreadable catalog (one warning) keep the code.
The sync summaries gain ProductNames Resolved/Unresolved. GetSingleRecord is
unchanged: the gateway doesn't use its ProductID for the mapping.

Includes a read-only catalog probe (V1 and V2 catalogs are identical on the sandbox).
…ad-only)

Explains why a gateway row isn't re-saved by the sync. Opt-in with
CERTINEXT_SYNC_PRODUCTID_PROBE=1 and CERTINEXT_PROBE_ORDERS. Live 2026-11-16: the 8
gateway rows still pending without a profile are all 'Order Cancelled | Rejected due
to Order Cancellation' (Track: cancelled), which the sync skips.
… still holds it as pending

Both syncs skip orders cancelled or rejected at CERTInext, and the gateway changes a
row only when the sync emits a record for it, so an order it held as pending stayed
pending indefinitely (8 kfclab rows, all 'Order Cancelled | Rejected due to Order
Cancellation', Track: cancelled). Before skipping, the sync now asks the gateway
(ICertificateDataReader.GetStatusByRequestID): held as pending -> emit failed with no
certificate, once. No row (ArgumentException), already terminal, issued/revoked
(never downgraded), no reader, or a lookup error keep the skip. Summaries gain
FailedPropagated. Issue 0098.
@spbsoluble
spbsoluble added this pull request to stack #45 November 17, 2026 03:19
spbsoluble and others added 3 commits November 16, 2026 20:02
…ildcard CN

A DV/OV request with CN = apex and SAN = *.apex failed with EMS-1173: the
wrapper keys "wildcard" on certificate.domain alone and resolved a plain
UCC product. Sending the wildcard as the domain is rejected too (EMS-1056,
the domain must match the CSR CN). Both confirmed live.

With no template ProductCode, the plugin now reads the catalog and sends
the account's single active Wildcard UCC product (typeID 21 DV / 22 OV) as
X-Product-Code. No match, several matches, a catalog failure, or EV fails
before any order is placed, asking for ProductCode.

Adds unit coverage and an opt-in live probe (CERTINEXT_V2_WILDCARD_SAN_PROBE).
spbsoluble and others added 2 commits November 17, 2026 12:04
…y from Command's SAN list (#50)

* fix(v2): don't block wildcard-SAN orders when the catalog can't name a Wildcard UCC product

A DV/OV request with CN = apex and SAN = *.apex and no template ProductCode
was rejected before ordering whenever the catalog didn't list exactly one
active product with productTypeID 21/22. Catalogs on other CA backends
(SSL.com) need not use those IDs, and there CERTInext accepts this shape
with no X-Product-Code. Now:

- One active Wildcard UCC product: its code is sent, as before.
- None, several, or an unreadable catalog: a warning is logged and the
  order is placed with no X-Product-Code. An EMS-1173 from CERTInext then
  says to set ProductCode on the template. EV still fails before ordering.
- Explicit ProductCode whose catalog entry has no documented SSL
  productTypeID (not listed, none, unfamiliar, or no catalog): UCC is
  decided from the request's SANs instead of rejecting extra SANs, and
  template save-time validation accepts the code instead of reporting a
  product mismatch.
- Flat catalog rows keyed by productCode are available when they carry no
  "active" field, and a numeric productTypeID no longer fails the read.

Also clears a CS8602 on the SSL.com organization check (the variant is
"ov" or "ev" there).

* test(live): raw wildcard-SAN probe, Private PKI variant/leave-pending switches, V1 enroll logging

- V2WildcardSanShapeTests.Probe_Raw_ApexCn_WildcardSan posts the create
  body directly (no X-Product-Code, CSR inline, CN = apex, SAN = *.apex),
  with and without additionalDomains.
- PrivatePkiV2LiveTests routes plugin logs to the test output and takes
  CERTINEXT_PRIVATE_PKI_VARIANT and CERTINEXT_PRIVATE_PKI_LEAVE_PENDING.
- DcvLifecycleTests.EnrollWithoutDcv_DoesNotInvokeDnsProvider routes
  plugin logs and prints the enroll result.

* docs: auto-generate README and documentation [skip ci]

* fix(v2): never add X-Product-Code on the plugin's own; send a template ProductCode as given

CERTInext advises sending only the variant and leaving X-Product-Code out.
Removes the catalog lookup that pinned a Wildcard UCC product (typeID 21/22)
for a wildcard SAN on a plain CN, along with its no-match fallback and
EMS-1173 hint. That request now goes out like any other: CN as the domain,
the wildcard in additionalDomains, no header unless the template sets
ProductCode, no catalog call. EV with a wildcard SAN is still rejected
before ordering. Drops the now-unused WildcardUccProductTypeIdByVariant.

* docs: auto-generate README and documentation [skip ci]

* fix(v2): remove product-code pre-checks and let CERTInext reject a code it can't use

V2 no longer checks a template ProductCode against the catalog:

- Enrollment never reads the catalog. Wildcard/UCC is decided from the
  request for every SSL order (domain "*.", UCC template product, or extra
  DNS SANs going out in additionalDomains), with or without ProductCode.
  The single-domain SAN guard, which could only reject an explicit code the
  catalog listed as non-UCC, is gone. An explicit code is sent as given.
- Template save (ValidateProductInfo) no longer looks the code up in the
  V2 catalog, for SSL or Private PKI. The ProductVariant, Private PKI
  variant and OV organization representative checks stay.
- EV with a wildcard SAN is still rejected before ordering.

V1 is unchanged: its template save still checks the code with
GetProfilesAsync. Drops the now-unused WildcardProductTypeIds and
PrivatePkiProductTypeId constants.

* docs: auto-generate README and documentation [skip ci]

* fix(v2): use Command's SAN list as the only source of extra names; address review findings

SAN source: FindExtraDnsSans took the union of the CSR's SANs and the
gateway's SAN dictionary, while additionalDomains came from the dictionary.
A DNS name only in the CSR made the order multi-domain yet was left out of
additionalDomains. Both now use CollectRequestedSanEntries: the dictionary,
or the CSR only when the dictionary is null. That matches the other
Keyfactor CA plugins that build a SAN list for their CA (DigiCert, Entrust,
Vault, GCP CAS, GoDaddy, Sectigo, GlobalSign, HydrantID, SSLStore, CSC):
dictionary only, CSR passed through, no union and no rejection.
BuildSanList, which V1 also uses, is unchanged.

Review findings:
- Drop the EV wildcard pre-check (it covered only a wildcard SAN, not a
  wildcard domain); CERTInext decides.
- Flat catalog rows: "active" is honored only as JSON true/false; a
  missing or null value is available, anything else isn't. The CHANGELOG
  no longer claims an Active fix (nothing reads it).
- The UCC log line no longer says the plugin "resolved" a product.
- Docs note that some accounts reject a wildcard-only-in-SANs request
  with EMS-1173, and that ProductCode is the way around it.
- Catalog_ListsProductTypeIds comment: informational only.

* docs: auto-generate README and documentation [skip ci]

* docs(changelog): consolidate the V2 product-code entries; add an upgrade note and known limitations

Merges the two overlapping X-Product-Code/ProductCode feature entries into one
that describes the final behavior, tightens the related fixes, adds an upgrade
note for earlier 2.0 builds (no save-time ProductCode check; CSR-only SAN names
ignored), and lists EMS-1173 on wildcard-only-in-SANs requests and the missing
live verification as known limitations.

* docs(changelog): drop test-environment references and meta notes from 2.0.0

Removes sandbox and live-test references, test dates, rationale asides and
the notes aimed at pre-release builds from the 2.0.0 entries, and the same
sandbox aside from the configuration doc.

* docs: auto-generate README and documentation [skip ci]

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
#51)

PR #50 removed V2's save-time ProductCode catalog check and the single-domain
SAN guard, but two live tests still described or asserted them:

- V2ApiTests.ValidateProductInfo_V2_RejectsUnknownProductCode expected an
  unknown code to be rejected at template save. Renamed to
  ValidateProductInfo_V2_AcceptsUnknownProductCode_WithoutCatalogCheck and
  now asserts it's accepted; ValidateProductInfo_V2_AcceptsConfiguredProductCode's
  reason no longer says the code must be in the catalog.
- V2FullLifecycleTests.Enroll_V2_WildcardDv_WildcardPlusApexSan_RecordsActualBehavior
  no longer attributes a FAILED result to the removed guard; it logs the
  result and cleans up any order created.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant